Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/190#discussion_r48283776
--- Diff:
engine/src/test/java/com/datatorrent/stram/engine/AutoMetricTest.java ---
@@ -361,6 +384,15 @@ public int getMyMetric()
}
}
+ public static class OperatorAndAggregator extends OperatorWithMetrics
implements AutoMetric.Aggregator
+ {
+ @Override
+ public Map<String, Object> aggregate(long windowId,
Collection<AutoMetric.PhysicalMetricsContext> physicalMetrics)
+ {
+ return null;
--- End diff --
I think this test aggregator method should actually do something, then
verify it in the testDefaultMetricsAggregator method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
