Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/154#discussion_r48795848
--- Diff:
contrib/src/test/java/com/datatorrent/contrib/parser/CsvPOJOParserTest.java ---
@@ -20,169 +20,425 @@
import java.util.Date;
-import org.joda.time.DateTime;
+import org.junit.After;
import org.junit.Assert;
-import org.junit.Rule;
+import org.junit.Before;
import org.junit.Test;
-import org.junit.rules.TestWatcher;
-import org.junit.runner.Description;
+import com.datatorrent.lib.appdata.schemas.SchemaUtils;
import com.datatorrent.lib.testbench.CollectorTestSink;
-import com.datatorrent.lib.util.TestUtils;
public class CsvPOJOParserTest
{
- CsvParser operator;
- CollectorTestSink<Object> validDataSink;
- CollectorTestSink<String> invalidDataSink;
+ private static final String filename = "schema.json";
+ CollectorTestSink<Object> error = new CollectorTestSink<Object>();
+ CollectorTestSink<Object> objectPort = new CollectorTestSink<Object>();
+ CollectorTestSink<Object> pojoPort = new CollectorTestSink<Object>();
+ CsvParser parser = new CsvParser();
- @Rule
- public Watcher watcher = new Watcher();
+ /*
+ *
adId,campaignId,adName,bidPrice,startDate,endDate,securityCode,isActive,isOptimized,parentCampaign,weatherTargeted,valid
+ * 1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,OPTIMIZE,CAMP_AD,Y,yes
+ * Constraints are defined in schema.json
+ */
- public class Watcher extends TestWatcher
+ @Before
+ public void setup()
{
+ parser.err.setSink(error);
+ parser.parsedOutput.setSink(objectPort);
+ parser.out.setSink(pojoPort);
+ parser.setClazz(Ad.class);
+ parser.setSchema(SchemaUtils.jarResourceFileToString(filename));
+ parser.setup(null);
+ }
- @Override
- protected void starting(Description description)
- {
- super.starting(description);
- operator = new CsvParser();
- operator.setClazz(EmployeeBean.class);
-
operator.setFieldInfo("name:string,dept:string,eid:integer,dateOfJoining:date");
- validDataSink = new CollectorTestSink<Object>();
- invalidDataSink = new CollectorTestSink<String>();
- TestUtils.setSink(operator.out, validDataSink);
- TestUtils.setSink(operator.err, invalidDataSink);
- }
+ @After
+ public void tearDown()
+ {
+ error.clear();
+ objectPort.clear();
+ pojoPort.clear();
+ }
- @Override
- protected void finished(Description description)
- {
- super.finished(description);
- operator.teardown();
- }
+ @Test
+ public void TestParserValidInput()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(1, objectPort.collectedTuples.size());
+ Assert.assertEquals(1, pojoPort.collectedTuples.size());
+ Assert.assertEquals(0, error.collectedTuples.size());
+ Object obj = pojoPort.collectedTuples.get(0);
+ Ad adPojo = (Ad)obj;
+ Assert.assertNotNull(obj);
+ Assert.assertEquals(Ad.class, obj.getClass());
+ Assert.assertEquals(1234, adPojo.getAdId());
+ Assert.assertTrue("adxyz".equals(adPojo.getAdName()));
+ Assert.assertEquals(0.2, adPojo.getBidPrice(), 0.0);
+ Assert.assertEquals(Date.class, adPojo.getStartDate().getClass());
+ Assert.assertEquals(Date.class, adPojo.getEndDate().getClass());
+ Assert.assertEquals(12, adPojo.getSecurityCode());
+ Assert.assertTrue("CAMP_AD".equals(adPojo.getParentCampaign()));
+ Assert.assertTrue(adPojo.isActive());
+ Assert.assertFalse(adPojo.isOptimized());
+ Assert.assertTrue("yes".equals(adPojo.getValid()));
+ }
+ @Test
+ public void TestParserValidInputPojoPortNotConnected()
+ {
+ parser.out.setSink(null);
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(1, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(0, error.collectedTuples.size());
}
@Test
- public void testCsvToPojoWriterDefault()
+ public void TestParserValidInputClassNameNotProvided()
{
- operator.setup(null);
- String tuple = "john,cs,1,01/01/2015";
- operator.in.process(tuple);
- Assert.assertEquals(1, validDataSink.collectedTuples.size());
- Assert.assertEquals(0, invalidDataSink.collectedTuples.size());
- Object obj = validDataSink.collectedTuples.get(0);
- Assert.assertNotNull(obj);
- Assert.assertEquals(EmployeeBean.class, obj.getClass());
- EmployeeBean pojo = (EmployeeBean)obj;
- Assert.assertEquals("john", pojo.getName());
- Assert.assertEquals("cs", pojo.getDept());
- Assert.assertEquals(1, pojo.getEid());
- Assert.assertEquals(new DateTime().withDate(2015, 1,
1).withMillisOfDay(0).withTimeAtStartOfDay(), new DateTime(
- pojo.getDateOfJoining()));
+ parser.setClazz(null);
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(1, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(0, error.collectedTuples.size());
}
@Test
- public void testCsvToPojoWriterDateFormat()
+ public void TestParserInvalidAdIdInput()
{
-
operator.setFieldInfo("name:string,dept:string,eid:integer,dateOfJoining:date|dd-MMM-yyyy");
- operator.setup(null);
- String tuple = "john,cs,1,01-JAN-2015";
- operator.in.process(tuple);
- Assert.assertEquals(1, validDataSink.collectedTuples.size());
- Assert.assertEquals(0, invalidDataSink.collectedTuples.size());
- Object obj = validDataSink.collectedTuples.get(0);
+ String input = ",98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserNoCampaignIdInput()
+ {
+ String input = "1234,,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(1, objectPort.collectedTuples.size());
+ Assert.assertEquals(1, pojoPort.collectedTuples.size());
+ Object obj = pojoPort.collectedTuples.get(0);
Assert.assertNotNull(obj);
- Assert.assertEquals(EmployeeBean.class, obj.getClass());
- EmployeeBean pojo = (EmployeeBean)obj;
- Assert.assertEquals("john", pojo.getName());
- Assert.assertEquals("cs", pojo.getDept());
- Assert.assertEquals(1, pojo.getEid());
- Assert.assertEquals(new DateTime().withDate(2015, 1,
1).withMillisOfDay(0).withTimeAtStartOfDay(), new DateTime(
- pojo.getDateOfJoining()));
+ Assert.assertEquals(Ad.class, obj.getClass());
+ Assert.assertEquals(0, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInvalidCampaignIdInput()
+ {
+ String input = "1234,9833,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
}
@Test
- public void testCsvToPojoWriterDateFormatMultiple()
+ public void TestParserInvalidAdNameInput()
{
-
operator.setFieldInfo("name:string,dept:string,eid:integer,dateOfJoining:date|dd-MMM-yyyy,dateOfBirth:date");
- operator.setup(null);
- String tuple = "john,cs,1,01-JAN-2015,01/01/2015";
- operator.in.process(tuple);
- Assert.assertEquals(1, validDataSink.collectedTuples.size());
- Assert.assertEquals(0, invalidDataSink.collectedTuples.size());
- Object obj = validDataSink.collectedTuples.get(0);
+ String input = "1234,98233,adxyz123,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInvalidBidPriceInput()
+ {
+ String input = "1234,98233,adxyz,3.3,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInvalidStartDateInput()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-30-08
02:37:12,11/12/2012,12,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInvalidSecurityCodeInput()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,85,y,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInvalidisActiveInput()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,yo,,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInvalidParentCampaignInput()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,,CAMP,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserValidisOptimized()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,OPTIMIZE,CAMP_AD,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(1, objectPort.collectedTuples.size());
+ Assert.assertEquals(1, pojoPort.collectedTuples.size());
+ Object obj = pojoPort.collectedTuples.get(0);
Assert.assertNotNull(obj);
- Assert.assertEquals(EmployeeBean.class, obj.getClass());
- EmployeeBean pojo = (EmployeeBean)obj;
- Assert.assertEquals("john", pojo.getName());
- Assert.assertEquals("cs", pojo.getDept());
- Assert.assertEquals(1, pojo.getEid());
- Assert.assertEquals(new DateTime().withDate(2015, 1,
1).withMillisOfDay(0).withTimeAtStartOfDay(), new DateTime(
- pojo.getDateOfJoining()));
- Assert.assertEquals(new DateTime().withDate(2015, 1,
1).withMillisOfDay(0).withTimeAtStartOfDay(), new DateTime(
- pojo.getDateOfBirth()));
+ Assert.assertEquals(Ad.class, obj.getClass());
+ Assert.assertEquals(0, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInValidisOptimized()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,OPTIMIZATION,CAMP,Y,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserInValidWeatherTargeting()
+ {
+ String input = "1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,OPTIMIZE,CAMP_AD,NO,yes";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserNullOrBlankInput()
+ {
+ parser.in.process(null);
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserHeaderAsInput()
+ {
+ String input =
"adId,campaignId,adName,bidPrice,startDate,endDate,securityCode,active,optimized,parentCampaign,weatherTargeted,valid";
+ parser.in.process(input.getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserLessFields()
+ {
+ parser.in.process("1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,OPTIMIZATION".getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
+ }
+
+ @Test
+ public void TestParserMoreFields()
+ {
+ parser.in.process("1234,98233,adxyz,0.2,2015-03-08
03:37:12,11/12/2012,12,y,OPTIMIZATION,CAMP_AD,Y,yes,ExtraField"
+ .getBytes());
+ parser.teardown();
+ Assert.assertEquals(0, objectPort.collectedTuples.size());
+ Assert.assertEquals(0, pojoPort.collectedTuples.size());
+ Assert.assertEquals(1, error.collectedTuples.size());
}
- public static class EmployeeBean
+ public static class Ad
--- End diff --
Could we not enhance EmployeeBean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
