[
https://issues.apache.org/jira/browse/APEXCORE-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089468#comment-15089468
]
ASF GitHub Bot commented on APEXCORE-268:
-----------------------------------------
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/199#discussion_r49207712
--- Diff:
common/src/main/java/com/datatorrent/common/metric/MetricsAggregator.java ---
@@ -129,13 +128,13 @@ public void addAggregators(@NotNull String metric,
@NotNull SingleMetricAggregat
* be used for the result of aggregators[i].
*/
public void addAggregators(@NotNull String metric, @NotNull
SingleMetricAggregator[] aggregators,
- @NotNull String[] logicalMetricNames)
+ @NotNull String[] logicalMetricNames)
{
Preconditions.checkNotNull(metric, "metric");
Preconditions.checkNotNull(aggregators, "aggregators");
Preconditions.checkNotNull(logicalMetricNames, "logicalMetricNames");
Preconditions.checkArgument(aggregators.length ==
logicalMetricNames.length, "different length aggregators and" +
- " logical names");
+ " logical names");
--- End diff --
Avoid split on the string literal. Can the previous line be split after the
comma?
> Fix existing checkstyle violations in common module
> ---------------------------------------------------
>
> Key: APEXCORE-268
> URL: https://issues.apache.org/jira/browse/APEXCORE-268
> Project: Apache Apex Core
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
