[ 
https://issues.apache.org/jira/browse/APEXCORE-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090810#comment-15090810
 ] 

ASF GitHub Bot commented on APEXCORE-268:
-----------------------------------------

Github user vrozov commented on the pull request:

    
https://github.com/apache/incubator-apex-core/pull/199#issuecomment-170287936
  
    The problem is not that it is impossible to invoke maven with custom 
parameters and achieve the desired result, IMO question and discussion is about 
default behavior. IMO, by default errors and warnings for checkstyle should be 
printed the same way they are printed for compile. This will give the most 
optimal default behavior that minimizes development effort to fix errors and 
warnings.
    
    @chandnisingh my suggestion is not to completely disable line length check, 
but to disable print out of those violations during default mvn invoke while 
outputting all other errors and warnings. It will be good to make final 
decision whether or not we allow lines that exceed 120 characters, but this is 
a separate from this pull request discussion.


> Fix existing checkstyle violations in common module
> ---------------------------------------------------
>
>                 Key: APEXCORE-268
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-268
>             Project: Apache Apex Core
>          Issue Type: Sub-task
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to