[
https://issues.apache.org/jira/browse/APEXMALHAR-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110156#comment-15110156
]
ASF GitHub Bot commented on APEXMALHAR-1977:
--------------------------------------------
Github user DT-Priyanka commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/172#discussion_r50365121
--- Diff:
library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPOJOInputOperator.java ---
@@ -97,6 +97,9 @@
protected int pageNumber;
+ @AutoMetric
+ protected long tuplesRead;
--- End diff --
As suggested by Gaurav keeping it protected so that the subclass can
update the metrics if required.
> Add metrics to jdbc input operator
> ----------------------------------
>
> Key: APEXMALHAR-1977
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-1977
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Priyanka Gugale
> Assignee: Priyanka Gugale
> Priority: Minor
> Original Estimate: 4h
> Remaining Estimate: 4h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
