Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/176#discussion_r51339726
--- Diff:
kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
@@ -366,17 +374,19 @@ public String getClusters()
return Joiner.on(';').join(clusters);
}
- public void setTopics(String... topics)
+ public void setTopics(String topics)
{
- this.topics = topics;
+ Topic.validate(topics.replace(" |,", "");
+ this.topics =
Iterables.toArray(Splitter.on(',').trimResults().omitEmptyStrings().split(topics),
String.class);
--- End diff --
This assumes that " " is also a valid separator for topics. I think it is
better to validate each topic separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
