Github user siyuanh commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/205#discussion_r54615024
  
    --- Diff: 
kafka/src/main/java/org/apache/apex/malhar/kafka/KafkaConsumerWrapper.java ---
    @@ -137,6 +189,9 @@ public void run()
     
     
             while (wrapper.isAlive) {
    +          if (wrapper.waitForReplay) {
    +            Thread.sleep(100);
    +          }
    --- End diff --
    
    And also this will be an issue in old kafka operator that the thread could 
receive duplicated messages because it start consuming data immediately when 
the operator is activated. The offset it starts from will have overlap with 
offsets in the recovery window, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to