[
https://issues.apache.org/jira/browse/APEXMALHAR-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203576#comment-15203576
]
ASF GitHub Bot commented on APEXMALHAR-1897:
--------------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/145#discussion_r56775333
--- Diff:
library/src/main/java/com/datatorrent/lib/state/managed/ManagedStateImpl.java
---
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.datatorrent.lib.state.managed;
+
+import java.util.concurrent.Future;
+
+import javax.validation.constraints.Min;
+
+import com.google.common.util.concurrent.Futures;
+
+import com.datatorrent.lib.state.BucketedState;
+import com.datatorrent.netlet.util.Slice;
+
+/**
+ * Basic implementation of {@link ManagedState} where window is used to
sub-group key of a particular bucket.<br/>
+ *
+ */
+public class ManagedStateImpl extends AbstractManagedStateImpl implements
BucketedState
+{
+
+ public ManagedStateImpl()
+ {
+ this.numBuckets = 1;
+ }
+
+ @Override
+ public void put(long bucketId, Slice key, Slice value)
+ {
+ long timeBucket = timeBucketAssigner.getTimeBucketFor(windowId);
+ if (timeBucket != -1) {
+ int bucketIdx = prepareBucket(bucketId);
+ buckets[bucketIdx].put(key, timeBucket, value);
+ }
+ }
+
+
+ @Override
+ public Slice getSync(long bucketId, Slice key)
+ {
+ int bucketIdx = prepareBucket(bucketId);
--- End diff --
This method should also acquire the bucket lock incase the user mixes
Synchronous and Asynchronous get calls.
> Create ManagedState
> -------------------
>
> Key: APEXMALHAR-1897
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-1897
> Project: Apache Apex Malhar
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Fix For: 3.4.0
>
>
> ManagedState is described in the document below:
> https://docs.google.com/document/d/1gRWN9ufKSZSZD0N-pthlhpC9TZ8KwJ6hJlAX6nxl5f8/edit#heading=h.z87ti1fwyt0t
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
