[
https://issues.apache.org/jira/browse/APEXMALHAR-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209579#comment-15209579
]
ASF GitHub Bot commented on APEXMALHAR-1897:
--------------------------------------------
Github user amberarrow commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/145#discussion_r57266129
--- Diff:
library/src/main/java/com/datatorrent/lib/state/managed/AbstractManagedStateImpl.java
---
@@ -226,6 +232,15 @@ protected int prepareBucket(long bucketId)
return bucketIdx;
}
+ protected void putInBucket(long bucketId, long timeBucket, Slice key,
Slice value)
+ {
+ if (timeBucket != -1) {
+ //time bucket is invalid data is not stored
--- End diff --
Suggest moving comment above the if and rephrasing:
// if time bucket is invalid, data is not stored
> Create ManagedState
> -------------------
>
> Key: APEXMALHAR-1897
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-1897
> Project: Apache Apex Malhar
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Fix For: 3.4.0
>
>
> ManagedState is described in the document below:
> https://docs.google.com/document/d/1gRWN9ufKSZSZD0N-pthlhpC9TZ8KwJ6hJlAX6nxl5f8/edit#heading=h.z87ti1fwyt0t
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
