[
https://issues.apache.org/jira/browse/APEXMALHAR-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217631#comment-15217631
]
ASF GitHub Bot commented on APEXMALHAR-2011:
--------------------------------------------
Github user chinmaykolhatkar commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r57850600
--- Diff:
contrib/src/main/java/com/datatorrent/contrib/avro/AvroRecordHelper.java ---
@@ -0,0 +1,120 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.datatorrent.contrib.avro;
+
+import java.text.ParseException;
+import java.util.List;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.avro.Schema;
+import org.apache.avro.Schema.Type;
+
+/**
+ * This is an utility class for reading Avro converted records
+ */
+public class AvroRecordHelper
--- End diff --
I see that this class is used only in PojoToAvro.getGenericRecord. Please
correct me if I'm wrong.
In that case, can you move this to that class itself as a private method?
> POJO to Avro record converter
> -----------------------------
>
> Key: APEXMALHAR-2011
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2011
> Project: Apache Apex Malhar
> Issue Type: New Feature
> Reporter: devendra tagare
>
> We are looking to develop a record converter which would take a POJO as an
> input and emit a Generic record as the output based on the given Avro schema.
> The expected inputs for this operator would be,
> 1.Class Name of the incoming POJO
> 2.Avro schema for the Generic Record to emit.
> This operator would receive an Object on its input port and emit a Generic
> record on the output port.
> To start with, we would handle primitive types and then go on to handle
> complex types.
> Thanks,
> Dev
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
