Github user chandnisingh commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/232#discussion_r58658808
  
    --- Diff: 
library/src/main/java/org/apache/apex/malhar/lib/spillable/Serde.java ---
    @@ -0,0 +1,42 @@
    +/*
    + * Copyright 2016 Apache Software Foundation.
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.apex.malhar.lib.spillable;
    +
    +import org.apache.commons.lang3.mutable.MutableInt;
    +
    +/**
    + * This is an interface for a Serializer/Deserializer class.
    + * @param <OBJ> The type of the object to Serialize and Deserialize.
    + * @param <SER> The type to Serialize an Object to.
    + */
    +public interface Serde<OBJ, SER>
    +{
    +  /**
    +   * Serialized the given object.
    +   * @param object The object to serialize.
    +   * @return The serialized representation of the object.
    +   */
    +  public SER serializeObject(OBJ object);
    +
    +  /**
    +   * Deserializes the given serialized representation of an object.
    +   * @param object The serialized representation of an object.
    +   * @param offset An offset in the serialized reprsentation of the object.
    +   * @return The deserialized object.
    +   */
    +  public OBJ deserializeObject(SER object, MutableInt offset);
    --- End diff --
    
    if this eases the following as @ilooner  mentioned 
    ```
    Object obj;
    MutableInt mi;
     someObj1 = deserialize(obj, mi);
     someObj2 = deserialize(obj, mi);
    So the implementation is expected to modify the offset, then this needs to 
be documented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to