[
https://issues.apache.org/jira/browse/APEXCORE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229358#comment-15229358
]
ASF GitHub Bot commented on APEXCORE-421:
-----------------------------------------
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/296#discussion_r58800303
--- Diff: engine/src/main/java/com/datatorrent/stram/engine/InputNode.java
---
@@ -241,11 +241,14 @@ else if (PROCESSING_MODE ==
ProcessingMode.EXACTLY_ONCE) {
if (++applicationWindowCount == APPLICATION_WINDOW_COUNT) {
applicationWindowCount = 0;
}
- if (++checkpointWindowCount == CHECKPOINT_WINDOW_COUNT) {
- checkpointWindowCount = 0;
- if (doCheckpoint || PROCESSING_MODE ==
ProcessingMode.EXACTLY_ONCE) {
- checkpoint(currentWindowId);
- lastCheckpointWindowId = currentWindowId;
+
+ if (lastCheckpointWindowId < currentWindowId) {
--- End diff --
can we add a small comment here that why this check is needed?
It helps others to understand
> Double Checkpointing May Happen In Input Node On Shutdown
> ---------------------------------------------------------
>
> Key: APEXCORE-421
> URL: https://issues.apache.org/jira/browse/APEXCORE-421
> Project: Apache Apex Core
> Issue Type: Bug
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> Double checkpointing can happen in input node when a shutdown is triggered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
