[
https://issues.apache.org/jira/browse/APEXCORE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230747#comment-15230747
]
ASF GitHub Bot commented on APEXCORE-10:
----------------------------------------
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/250#discussion_r58918937
--- Diff:
engine/src/main/java/com/datatorrent/stram/BlacklistBasedResourceRequestHandler.java
---
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.datatorrent.stram;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+
+import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.tuple.MutablePair;
+import org.apache.hadoop.yarn.client.api.AMRMClient;
+import org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.datatorrent.stram.StreamingContainerAgent.ContainerStartRequest;
+
+/**
+ * Handles creating container requests and issuing node-specific container
+ * requests by blacklisting (specifically for cloudera)
+ *
+ * Host specific container requests are not allocated on Cloudera as
captured in
+ * Jira Yarn-1412 (https://issues.apache.org/jira/browse/YARN-1412)
+ * To handle such requests, we blacklist all the other nodes before
issueing node request.
+ */
+public class BlacklistBasedResourceRequestHandler extends
ResourceRequestHandler
+{
+ HashMap<ContainerRequest, ContainerStartRequest> hostSpecificRequests =
new HashMap<>();
+ HashMap<ContainerRequest, ContainerStartRequest> otherContainerRequests
= new HashMap<>();
+ HashMap<String, List<ContainerRequest>> hostSpecificRequestsMap = new
HashMap<>();
+ List<String> blacklistedNodesForHostSpecificRequests = null;
+
+ public void reissueContainerRequests(AMRMClient<ContainerRequest>
amRmClient, Map<StreamingContainerAgent.ContainerStartRequest,
MutablePair<Integer, ContainerRequest>> requestedResources, int loopCounter,
ResourceRequestHandler resourceRequestor, List<ContainerRequest>
containerRequests, List<ContainerRequest> removedContainerRequests)
+ {
+ // Issue all host specific requests first
+ if (!hostSpecificRequestsMap.isEmpty() &&
requestedResources.isEmpty()) {
+ LOG.info("Issue Host specific requests first");
+ // Blacklist all the nodes and issue request for host specific
+ Entry<String, List<ContainerRequest>> set =
hostSpecificRequestsMap.entrySet().iterator().next();
+ List<ContainerRequest> requests = set.getValue();
+ List<String> blacklistNodes =
resourceRequestor.getNodesExceptHost(requests.get(0).getNodes());
+ amRmClient.updateBlacklist(blacklistNodes,
requests.get(0).getNodes());
+ blacklistedNodesForHostSpecificRequests = blacklistNodes;
+ LOG.info("Sending {} request(s) after blacklisting nodes {} and
removed host from request {}", requests.size(), blacklistNodes,
requests.get(0).getNodes());
--- End diff --
I still have a concern with the logging of potentially very large
collections of nodes (consider cluster size).
> Enable non-affinity of operators per node (not containers)
> ----------------------------------------------------------
>
> Key: APEXCORE-10
> URL: https://issues.apache.org/jira/browse/APEXCORE-10
> Project: Apache Apex Core
> Issue Type: Task
> Reporter: Amol Kekre
> Assignee: Isha Arkatkar
> Labels: roadmap
>
> The issue happens on cloud which provides virtual cores with software like
> Xen underneath. In effect if CPU intensive operators land up on same node we
> have a resource bottleneck,
> Need to create an attribute that does the following
> - Operators A & B should not be on same node
> - Stram should use this attribute to try to get containers on different node
> It is understood that the user is making an explicit choice to use NIC
> instead of stream local optimization
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
