[ 
https://issues.apache.org/jira/browse/APEXCORE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233038#comment-15233038
 ] 

ASF GitHub Bot commented on APEXCORE-411:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/294#discussion_r59095579
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/client/StramAppLauncher.java ---
    @@ -203,21 +231,75 @@ public StramAppLauncher(FileSystem fs, Path path, 
Configuration conf) throws Exc
         this.fs = fs;
         fs.copyToLocalFile(path, new Path(localJarFile.getAbsolutePath()));
         this.jarFile = localJarFile;
    +    this.conf = conf;
         this.propertiesBuilder = new LogicalPlanConfiguration(conf);
         init(this.jarFile.getName());
       }
     
       public StramAppLauncher(String name, Configuration conf) throws Exception
       {
         this.propertiesBuilder = new LogicalPlanConfiguration(conf);
    +    this.conf = conf;
         init(name);
       }
     
    +  public StramAppLauncher(FileSystem fs, Configuration conf) throws 
Exception
    +  {
    +    this.propertiesBuilder = new LogicalPlanConfiguration(conf);
    +    this.fs = fs;
    +    this.conf = conf;
    +    init();
    +  }
    +
       public String getMvnBuildClasspathOutput()
       {
         return mvnBuildClasspathOutput.toString();
       }
     
    +  /**
    +   * This is for recovering an app without specifying apa or appjar file
    --- End diff --
    
    Might be better to move the comment on the constructor?


> Restart app without specifying app package
> ------------------------------------------
>
>                 Key: APEXCORE-411
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-411
>             Project: Apache Apex Core
>          Issue Type: New Feature
>            Reporter: David Yan
>            Assignee: David Yan
>             Fix For: 3.4.0
>
>
> In the CLI, the launch command with -originalAppId requires the specification 
> of the app package.  This should be made optional because the app directory 
> of the original app already contains the jar files necessary to restart the 
> app.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to