[ 
https://issues.apache.org/jira/browse/APEXCORE-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234865#comment-15234865
 ] 

Chinmay Kolhatkar commented on APEXCORE-340:
--------------------------------------------

Made following changes in my fork: 
https://github.com/chinmaykolhatkar/incubator-apex-core/tree/APEXCORE-340
1. Script name changed to apex. Created dtcli as symlink to apex
2. Class name changed to ApexCli from DTCli. Similar for test class.
3. Changed console prompt to "apex>" from "dt>"
4. Changed Welcome message to "Apex CLI ..." from "DT CLI ..."

Commit link is: 
https://github.com/chinmaykolhatkar/incubator-apex-core/commit/5ef35e83323504027aef115dd01f7278c69cb1c1

Verified with unit test and launching pi demo.

Before I create a PR, I have some questions:
1. [~sandesh] : Even though there is dtcli symlink to apex, the prompt of the 
cli will change to "apex>" from "dtcli>"... Would that cause any problem in 
yahoo streaming benchmark? 

2. [~davidyan] [~thw] : We There are still traces of "dt" all over in this. 
For eg. ".dt" folder, DT_CLASSPATH and other such variables in script.  Should 
those also be changed as a part of this?




> Rename dtcli script to apex
> ---------------------------
>
>                 Key: APEXCORE-340
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-340
>             Project: Apache Apex Core
>          Issue Type: Task
>            Reporter: Thomas Weise
>            Assignee: Chinmay Kolhatkar
>
> As we are integrating Apex into other packages, we should make the name 
> change as soon as possible to avoid widespread downstream rework in the 
> future. The backward compatibility issue can be handled with symlink in DT 
> distro.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to