Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/301#discussion_r59320988
--- Diff:
engine/src/main/java/com/datatorrent/stram/stream/InlineStream.java ---
@@ -80,14 +88,29 @@ public void teardown()
public void put(Object tuple)
{
try {
- super.put(tuple);
+ reservoir.put(tuple);
+ if (!(tuple instanceof Tuple)) {
--- End diff --
I saw that :-) But since we are benchmarking plain stream performance and
spending time and effort enhancing the same, we should probably also quantify
this. Have you measured before/after?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
