[ 
https://issues.apache.org/jira/browse/APEXCORE-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244037#comment-15244037
 ] 

ASF GitHub Bot commented on APEXCORE-422:
-----------------------------------------

Github user chandnisingh commented on the pull request:

    
https://github.com/apache/incubator-apex-core/pull/309#issuecomment-210743348
  
    @tweise In this PR we reverted the change that would have required the 
release of a new artifact. So if we include this change then we don't have to 
release the new checkstyle artifact.
    
    Right now there is a problem with Checkstyle for which we have to file a 
bug with them. However this bug affected only 2 usages - PhysicalPlan and DTCli 
because of which while fixing the violations in engine, 
```AnnotationLocation``` check was suppressed in all the classes.
    Suppressing it for all classes will lead to introduction of valid 
violations in new changes. 


> Checkstyle rule related to allowSamelineParameterizedAnnotation should be 
> just suppressed for DTCli and PhysicalPlan
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: APEXCORE-422
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-422
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>             Fix For: 3.4.0
>
>
> The ticket was open to address the following issue which was reverted:
> Right now we are not letting users to write the following
> {code}
> for (@SuppressWarnings("deprecation") 
> com.datatorrent.api.StatsListener.OperatorCommand cmd : rsp
>               .operatorCommands)
> {code}
> We should suppress this rule only for DtCli and Physical Plan



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to