Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/311#discussion_r60113016
  
    --- Diff: api/src/main/java/com/datatorrent/api/StreamingApplication.java 
---
    @@ -47,6 +47,12 @@
       String ENVIRONMENT = DT_PREFIX + "environment";
     
       /**
    +   * Use this config variable to to add any external library to classpath 
for the DAG.
    +   * Value of this variable is same as 
StramAppLauncher.LIBJARS_CONF_KEY_NAME.
    +   */
    +  String LIBJARS_CONF_KEY_NAME = "tmplibjars";
    --- End diff --
    
    Just looking at the string literal suggests something isn't right here. We 
configure applications through attributes, not random properties in the config 
file. Can you please check if there is a better way to express this dependency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to