[
https://issues.apache.org/jira/browse/APEXMALHAR-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248018#comment-15248018
]
ASF GitHub Bot commented on APEXMALHAR-1965:
--------------------------------------------
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/242#discussion_r60257017
--- Diff: library/src/main/java/org/apache/apex/malhar/lib/wal/WAL.java ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.apex.malhar.lib.wal;
+
+import java.io.IOException;
+
+/**
+ * This interface represents a write ahead log that can be used by
operator.
+ * the WAL is split into two interfaces, a WALWriter which allows writing
+ * data, and WALReader which provides iterator like interface to read
entries
+ * written to the WAL.
+ *
+ * @param <READER> Type of WAL Reader
+ * @param <WRITER> WAL Pointer Type.
+ */
+public interface WAL<READER extends WAL.WALReader, WRITER extends
WAL.WALWriter>
+{
+ void setup();
+
+ void teardown();
+
+ void beforeCheckpoint(long window);
+
+ void committed(long window);
+
+ READER getReader();
+
+ WRITER getWriter();
+
+ /**
+ * Provides iterator like interface to read entries from the WAL.
+ * @param <T> type of WAL entries
+ * @param <P> type of Pointer in the WAL
+ */
+ interface WALReader<T, P>
+ {
+ /**
+ * Seek to middle of the WAL. This is used primarily during recovery,
+ * when we need to start recovering data from middle of WAL file.
+ */
+ void seek(P pointer) throws IOException;
+
+ /**
+ * Advance WAL by one entry, returns true if it can advance, else false
--- End diff --
Why separate advance and get?
> Create a WAL in Malhar
> ----------------------
>
> Key: APEXMALHAR-1965
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-1965
> Project: Apache Apex Malhar
> Issue Type: Task
> Reporter: Chandni Singh
> Assignee: Tushar Gosavi
>
> In Malhar we have an IdempotentStorageManager which we use like a Write Ahead
> Logger. There have been some other places where we have created a different
> flavor of Write Ahead Logger.
> We need to find overlap between all these flavors and create a common Write
> Ahead Logger for use in Apex core and Apex malhar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
