[ 
https://issues.apache.org/jira/browse/APEXCORE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255502#comment-15255502
 ] 

ASF GitHub Bot commented on APEXCORE-439:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/314#discussion_r60839381
  
    --- Diff: 
engine/src/main/java/com/datatorrent/stram/plan/physical/PhysicalPlan.java ---
    @@ -979,6 +998,14 @@ public void deployChanges() {
         this.undeployOpers.removeAll(newOpers.keySet());
         //make sure all the new operators are included in deploy operator list
         this.deployOpers.addAll(this.newOpers.keySet());
    +    // redeploy dependencies of the new operators excluding the new 
operators themselves
    +    Set<PTOperator> ndeps = getDependents(newOpers.keySet());
    +    ndeps.removeAll(newOpers.keySet());
    +    // don't redeploy operators already going to be undeployed
    +    ndeps.removeAll(this.undeployOpers);
    +    // redeploy remaining dependencies
    +    this.undeployOpers.addAll(ndeps);
    +    this.deployOpers.addAll(ndeps);
    --- End diff --
    
    This shouldn't be required. Next line already includes dependencies.


> After dynamic repartition application appears blocked
> -----------------------------------------------------
>
>                 Key: APEXCORE-439
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-439
>             Project: Apache Apex Core
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Munagala V. Ramanath
>            Assignee: Munagala V. Ramanath
>
> When a file input operator (subclass of AbstractFileInputOperator) is 
> dynamically repartitioned, some downstream unifiers are not identified as 
> needing to be redeployed causing the window id to not advance and all 
> downstream operators to be killed and restarted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to