[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255809#comment-15255809
 ] 

ASF GitHub Bot commented on APEXMALHAR-2065:
--------------------------------------------

Github user chandnisingh commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/255#discussion_r60858878
  
    --- Diff: 
library/src/main/java/org/apache/apex/malhar/lib/wal/WindowDataManager.java ---
    @@ -227,6 +235,22 @@ public void delete(int operatorId, long windowId) 
throws IOException
           return storageAgent.getWindowIds(operatorId);
         }
     
    +    @Override
    +    public long[] getWindowIds() throws IOException
    +    {
    +      SortedSet<Long> windowIds = replayState.keySet();
    +      long[] windowIdsArray = new long[windowIds.size()];
    +
    +      int index = 0;
    +
    +      for (Long windowId: windowIds) {
    +        windowIdsArray[index] = windowId;
    +        index++;
    +      }
    +
    +      return windowIdsArray;
    +    }
    --- End diff --
    
    Can you please document that windows ids are sorted?


> Add getWindows() method to WindowDataManager
> --------------------------------------------
>
>                 Key: APEXMALHAR-2065
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2065
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> This method will return all the windows id's across all partitions for which 
> there is data.
> This method is required for dynamic repartitioning of Managed State because 
> the data for all the partitions must be loaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to