[ 
https://issues.apache.org/jira/browse/APEXCORE-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263589#comment-15263589
 ] 

ASF GitHub Bot commented on APEXCORE-107:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/313#discussion_r61536670
  
    --- Diff: 
engine/src/test/java/com/datatorrent/stram/plan/logical/module/TestModuleExpansion.java
 ---
    @@ -184,7 +190,7 @@ public void setPortMemory(int portMemory)
         }
       }
     
    -  static class Level2ModuleA implements Module
    +  public static class Level2ModuleA extends BaseOperator implements Module
    --- End diff --
    
    Why these changes?


> Support adding module to application using property file API.
> -------------------------------------------------------------
>
>                 Key: APEXCORE-107
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-107
>             Project: Apache Apex Core
>          Issue Type: Task
>            Reporter: Tushar Gosavi
>            Assignee: Tushar Gosavi
>
> Add support for adding modules in the DAG specified through property file and 
> json file. The sample json format is specified below.
> {code}
> {
>   "operators": [
>     {
>       "name": "operator1",
>       "class": "com.datatorrent.lib.operator.Input",
>       "properties": {
>         "property1": "value1"
>       }
>     },
>     {
>       "name": "module1",
>       "class": "com.datatorrent.module.Module1",
>       "properties": {
>         "property1": "value1"
>       }
>     },
>   ],
>   "streams": [
>     {
>       "name": "s1",
>       "source": {
>         "operatorName": "operator1",
>         "portName": "output"
>       },
>       "sinks": [
>         {
>           "operatorName": "module",
>           "portName": "input"
>         }
>       ]
>     }
>   ]
> }
> {code}
> For this to work, we will need to support adding module in DAG through 
> property file API.
> This will allow external tools to visually construct the DAG containing 
> modules.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to