[
https://issues.apache.org/jira/browse/APEXMALHAR-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264530#comment-15264530
]
ASF GitHub Bot commented on APEXMALHAR-2068:
--------------------------------------------
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/259#discussion_r61627655
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -96,7 +96,7 @@ public FileSplitterInput()
{
super();
currentWindowRecoveryState = Lists.newLinkedList();
- idempotentStorageManager = new
IdempotentStorageManager.FSIdempotentStorageManager();
+ idempotentStorageManager = new
IdempotentStorageManager.NoopIdempotentStorageManager();
--- End diff --
I understand why we don't want to use FSIdempotentStorageManger in
FileSplitter as FileSplitter is more generic than FS. However I think setting
Noop disables idempotency by default. How about letting the user knowingly make
that choice by not creating it in the operator and set to @NotNull so the user
will have to set it.
> FileSplitter- having multiple file splitters in an application results in
> incorrect behavior
> --------------------------------------------------------------------------------------------
>
> Key: APEXMALHAR-2068
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2068
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> If an application has multiple logical operators that use Window Data
> Manager, then by default they share the same state. This is confusing and
> cause issues.
> We need to make this path unique by default for each logical instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
