[
https://issues.apache.org/jira/browse/APEXMALHAR-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277019#comment-15277019
]
ASF GitHub Bot commented on APEXMALHAR-2081:
--------------------------------------------
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/267#discussion_r62571190
--- Diff:
library/src/main/java/com/datatorrent/lib/io/block/BlockMetadata.java ---
@@ -227,37 +226,10 @@ public String getFilePath()
return filePath;
}
- /**
- * Get if blocks should be read in sequence
- * @return readBlockInSequence
- */
- public boolean isReadBlockInSequence()
--- End diff --
I mentioned in the discussion that the way this was accomplished is hacky.
The correct way of doing this is by setting a StreamCodec which I changed
in FSInputModule
> Remove FSFileSplitter, BlockReader, HDFSFileSplitter, HDFSInputModule
> ---------------------------------------------------------------------
>
> Key: APEXMALHAR-2081
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2081
> Project: Apache Apex Malhar
> Issue Type: Bug
> Components: adapters other
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Priority: Critical
> Fix For: 3.4.0
>
>
> Recently there was an FSFileSplitter added to the library.
> This operator adds 2 additional properties which can be added to the base
> operator.
> A problem with this approach of adding new extension which just add small
> features is that it confuses the users of which Operator to use and
> essentially we have multiple operators with the same basic functionality.
> This should be done before the new version of Malhar is released.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
