+1. Agree with you Bhupesh. We need to have consistent behaviour across all the operators.
As Kafka 0.9 project is still evolving, I don't see any backward compatibility issues. Regards, Sandeep On Wed, May 11, 2016 at 1:11 PM, Bhupesh Chawda <[email protected]> wrote: > Hi Thomas, > > In my application, I am trying to configure this operator using a user > interface. The getters and setters for *topics* (for example) are as > follows: > > String[] topics; > > public String getTopics() > public void setTopics(String topics) > > This is not considered consistent behaviour by the UI tool and hence it > either deems the operator invalid or does not allow setting this property > for the operator. Such could be the case with other UI tools as well. > > Additionally it makes sense to have getters and setters for a property, > accept the same data-type as the property and not make them arbitrarily > complex. > > Thanks > ~Bhupesh > > > On Wed, May 11, 2016 at 12:16 AM, Thomas Weise <[email protected]> > wrote: > > > What are the issues that you have observed? > > > > > > On Wed, May 11, 2016 at 12:08 AM, Bhupesh Chawda < > [email protected]> > > wrote: > > > > > Hi All, > > > > > > The fields in Kafka Input Operator in Malhar kafka project are of type > > > String array. However the getters and setters are not consistent and > > have a > > > return type and parameters of String type respectively. > > > This may cause issues in down stream systems and hence must be fixed. I > > > have created a JIRA to track this - > > > https://issues.apache.org/jira/browse/APEXMALHAR-2084 > > > > > > I am proposing that the types of these fields be made List<String> > > instead > > > of String[ ]. Additionally also make the getters and setters accept > > > parameters and return data of the same type. > > > > > > Please let me know your thoughts on the same. > > > > > > Thanks > > > ~Bhupesh > > > > > >
