Github user gauravgopi123 commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/243#discussion_r63084018
  
    --- Diff: 
contrib/src/test/java/com/datatorrent/contrib/parser/CsvPOJOParserTest.java ---
    @@ -319,6 +331,19 @@ public void TestParserMoreFields()
       }
     
       @Test
    +  public void TestParserMoreFieldsOnlyPOJOPortConnected()
    +  {
    +    parser.parsedOutput.setSink(null);
    +    parser.beginWindow(0);
    +    parser.in.process(
    +        "1234,98233,adxyz,0.2,2015-03-08 
03:37:12,11/12/2012,12,y,OPTIMIZATION,CAMP_AD,Y,yes,ExtraField".getBytes());
    +    parser.endWindow();
    +    Assert.assertEquals(0, objectPort.collectedTuples.size());
    +    Assert.assertEquals(0, pojoPort.collectedTuples.size());
    +    Assert.assertEquals(1, error.collectedTuples.size());
    --- End diff --
    
    Can you add small addition to make sure that error port has same string 
tuple that was passed on input port?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to