Github user sandeepdeshmukh commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/269#discussion_r63176671
  
    --- Diff: 
library/src/test/java/com/datatorrent/lib/db/jdbc/JdbcOperatorTest.java ---
    @@ -375,14 +411,37 @@ public void testJdbcPojoInputOperator()
         OperatorContextTestHelper.TestIdOperatorContext context = new 
OperatorContextTestHelper.TestIdOperatorContext(
             OPERATOR_ID, attributeMap);
     
    -    insertEventsInTable(10);
    --- End diff --
    
    I would still make it a function as the test case becomes more readable 
with this function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to