Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/334#discussion_r63448654
--- Diff:
engine/src/main/java/com/datatorrent/stram/client/StramClientUtils.java ---
@@ -739,13 +745,21 @@ public static InetSocketAddress
getRMWebAddress(Configuration conf, String rmId)
public static InetSocketAddress getRMWebAddress(Configuration conf,
boolean sslEnabled, String rmId)
{
- rmId = (rmId == null) ? "" : ("." + rmId);
+ boolean isHA = (rmId != null);
+ rmId = isHA ? ("." + rmId) : "";
--- End diff --
Should modification to `rmId` be done after the call to
`conf.set(ConfigUtils.RM_HA_ID, rmId)`? It is not modified in
`getRMHAAddress()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
