[
https://issues.apache.org/jira/browse/APEXMALHAR-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286035#comment-15286035
]
ASF GitHub Bot commented on APEXMALHAR-2073:
--------------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/276#discussion_r63463982
--- Diff:
library/src/main/java/org/apache/apex/malhar/lib/state/managed/IncrementalCheckpointManager.java
---
@@ -188,8 +190,12 @@ protected void committed(int operatorId, long
windowId) throws IOException, Inte
{
LOG.debug("data manager committed {}", windowId);
for (Long currentWindow : savedWindows.keySet()) {
+ if (currentWindow <= smallestPendingWindow) {
+ continue;
+ }
if (currentWindow <= windowId) {
- LOG.debug("to transfer {}", windowId);
+ LOG.debug("to transfer {}", currentWindow);
+ smallestPendingWindow = currentWindow;
--- End diff --
can the name be changed of smallestPendingWindow. It can be slightly
misleading.
> Intermittent test case failure:
> ManagedStateImplTest.testFreeWindowTransferRaceCondition:200 » NullPointer
> ----------------------------------------------------------------------------------------------------------
>
> Key: APEXMALHAR-2073
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2073
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Sandeep Deshmukh
> Assignee: Chandni Singh
> Priority: Critical
> Attachments: APEXMALHAR-2073.log
>
>
> The following test case is intermittently failing in Malhar:
> ManagedStateImplTest.testFreeWindowTransferRaceCondition:200 » NullPointer
> I observed this couple of times on my machine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
