[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286320#comment-15286320
 ] 

ASF GitHub Bot commented on APEXMALHAR-2082:
--------------------------------------------

Github user pradeepdalvi commented on a diff in the pull request:

    
https://github.com/apache/incubator-apex-malhar/pull/270#discussion_r63494078
  
    --- Diff: library/src/test/java/com/datatorrent/lib/filter/FilterTest.java 
---
    @@ -0,0 +1,165 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package com.datatorrent.lib.filter;
    +
    +import org.junit.AfterClass;
    +import org.junit.Assert;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * Tests for FilterOperator
    + */
    +public class FilterTest
    +{
    +  private static final Logger logger = 
LoggerFactory.getLogger(FilterTest.class);
    +
    +  public static class DummyPrivatePOJO
    +  {
    +    private long val;
    +
    +    public long getVal()
    +    {
    +      return val;
    +    }
    +
    +    public void setVal(long val)
    +    {
    +      this.val = val;
    +    }
    +  }
    +
    +  public static class DummyPublicPOJO
    +  {
    +    public long val;
    +  }
    +
    +
    +  private static FilterOperator filter;
    +  private static DummyPrivatePOJO data;
    +  private static DummyPublicPOJO pdata;
    +
    +  @Test
    +  public void testFilterPrivate()
    +  {
    +    filter.inClazz = DummyPrivatePOJO.class;
    +    filter.setCondition("({$}.getVal() == 100)");
    +    filter.activate(null);
    +
    +    /* when condition is true */
    +    logger.debug("start round 0");
    +    filter.beginWindow(0);
    +
    +    data.setVal(100);
    +    filter.input.process(data);
    --- End diff --
    
    Done


> Data Filter Operator 
> ---------------------
>
>                 Key: APEXMALHAR-2082
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2082
>             Project: Apache Apex Malhar
>          Issue Type: New Feature
>            Reporter: Pradeep A Dalvi
>
> Data Filter Operator which will allow apex users to filter (select/drop) 
> tuples based on the certain condition from incoming stream.
> Use case:
> -------------
> In many cases, not all tuples are of interest for the downstream operators. 
> In such cases, one may want select/filter out tuples to downstream. Also one 
> may want to process tuples which did not meet the condition/expression.
> Functionality:
> -----------------
> 1. Any tuple for which expression could not be evaluated shall be emitted on 
> error output port.
> 2. Filter operator shall receive POJO as input tuple and emit POJO on either 
> of remaining output ports i.e. truePort and falsePort. As the output ports' 
> name signify, when condition is met then the POJO shall be emitted on 
> truePort and if condition is not met then that POJO shall be emitted on 
> falsePort.
> 3. Operator needs condition/expression as a input param. This condition is 
> based on expression language support we already have in Malhar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to