Hello,

Thank you for the comments.
Here is the pull request for the enhancement
https://github.com/apache/incubator-apex-malhar/pull/269

With this change, the user will be able to provide POJO with Date, Time and
DateTime fields.
Long field for Date/Time/Timestamp will no longer be supported.

As the class is marked as Evolving, this change will not affect backward
compatibility as well.


Thanks,
Shubham


On Mon, May 9, 2016 at 11:31 PM, Bhupesh Chawda <[email protected]>
wrote:

> +1
> Having Date field will make it more intuitive.
> Additionally Date is timezone independent, so all timezone conversions have
> to be taken care of, by the user code.
>
> ~Bhupesh
>
> On Mon, May 9, 2016 at 6:33 AM, Sandeep Deshmukh <[email protected]>
> wrote:
>
> > +1 on being consistent in the ecosystem.
> > On 09-May-2016 6:51 pm, "Shubham Pathak" <[email protected]>
> wrote:
> >
> > > Yes, we can surely do the conversion. But we should also consider
> > usability
> > > and consistency across operators.
> > > Operators such as JSON Parser, CSV Parser emit POJOs and have the
> ability
> > > to define Date fields in POJO. Having similar ability in
> > > JdbcPOJOInputOperator will make it consistent.
> > > It would also be flexible as a user can easily plug in/ replace
> operator
> > (
> > > that emits POJO ) without having to handle conversions in the
> downstream
> > > operator.
> > >
> > > Thanks,
> > > Shubham
> > >
> > > On Wed, May 4, 2016 at 11:22 PM, Priyanka Gugale <
> > [email protected]
> > > >
> > > wrote:
> > >
> > > > Java many times preserve date as long and then we can convert it the
> > way
> > > we
> > > > want when we need to interface with other systems (like UI, DB or
> etc).
> > > We
> > > > can still do conversion from one date format to other, but I would
> > prefer
> > > > to keep it raw and convert in required format when need arise.
> > > >
> > > > -Priyanka
> > > >
> > > > On Tue, May 3, 2016 at 11:13 PM, Pradeep Kumbhar <
> > > [email protected]>
> > > > wrote:
> > > >
> > > > > +1 for the change.
> > > > > At some point in time, user'll need this to specify fields related
> to
> > > > time
> > > > > more meaningfully.
> > > > >
> > > > > On Wed, May 4, 2016 at 10:17 AM, Sandeep Deshmukh <
> > > > [email protected]
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > +1.
> > > > > > Good to have intuitive way of using fields.
> > > > > >
> > > > > > Regards,
> > > > > > Sandeep
> > > > > >
> > > > > > On Wed, May 4, 2016 at 9:39 AM, Shubham Pathak <
> > > > [email protected]>
> > > > > > wrote:
> > > > > >
> > > > > > > Hello Community,
> > > > > > >
> > > > > > > JdbcPOJOInputOperator reads from a database using JDBC API and
> > > emits
> > > > a
> > > > > > POJO
> > > > > > > for each record.
> > > > > > >
> > > > > > > In the  current implementation, Date/Time/Timestamp fields of
> the
> > > > table
> > > > > > are
> > > > > > > mapped to "long" field in POJO. While this works fine, it is
> not
> > > > > > intuitive.
> > > > > > >
> > > > > > > I would like to enhance the operator so that user can specify
> > > fields
> > > > > with
> > > > > > > the type Date/Time/Timestamp in POJO.
> > > > > > >
> > > > > > > Please let me know your thoughts on this.
> > > > > > >
> > > > > > > Here's the JIRA ticket
> > > > > > > https://issues.apache.org/jira/browse/APEXMALHAR-2075
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Shubham
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > *regards,*
> > > > > *~pradeep*
> > > > >
> > > >
> > >
> >
>

Reply via email to