[
https://issues.apache.org/jira/browse/APEXMALHAR-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287410#comment-15287410
]
ASF GitHub Bot commented on APEXMALHAR-2078:
--------------------------------------------
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/268#discussion_r63591292
--- Diff:
library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -515,6 +521,9 @@ protected ScannedFileInfo createScannedFileInfo(Path
parentPath, FileStatus pare
protected static boolean skipFile(@SuppressWarnings("unused") @NotNull
Path path, @NotNull Long modificationTime,
Long lastModificationTime) throws IOException
{
+ if(lastModificationTime == null) {
--- End diff --
The check lastModificationTime == null becomes redundant in the next line.
Why was this change necessary?
Please revert it.
> Potential thread issue in FileSplitterInput class
> -------------------------------------------------
>
> Key: APEXMALHAR-2078
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2078
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Priyanka Gugale
> Assignee: Priyanka Gugale
> Fix For: 3.4.0
>
>
> The "inputDirTolastModifiedTimes" field is modified by multiple threads and
> check pointed by operator thread. This could cause threading issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
