Cool, it's time to do that. Thanks, Ming Wen, Apache APISIX Twitter: _WenMing
Zhiyuan Ju <[email protected]> 于2019年11月7日周四 上午11:59写道： > Hi Ming, > > I have merged two Feature PRs just now and removed all unused files as > possible as I can, also I just updated the incubator-apisix-dashboard-built > repository, so I think if it's a good time to add MIT License Headers to > those existing original files? [1] > > [1] https://github.com/apache/incubator-apisix-dashboard/issues/66 > > Best Regards! > @ Zhiyuan Ju <https://www.shaoyaoju.org/> > > > Justin Mclean <[email protected]> 于2019年11月6日周三 上午7:30写道： > > > Hi, > > > > > 3. start developing: create our needed files or modify existing files; > > > > You'll need to distinguish between the files you have created and their > > files. I would suggest adding a MIT header to their files to make it > clear > > where they are from and that they are not ALv2. > > > > If you have headily modified one of their files when discuss here if the > > header should change to an ALv2 one, in general it should not. > > > > Thanks, > > Justin > > > > >
