Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE and NOTICE good
- no unexpected binary files in release
- all source file have ASF headers
Tested using the CentOS7 system, the verification, compilation,
installation, and startup process are normal.
Server Info:
LSB Version: core-4.1-amd64:core-4.1-noarch
Distributor ID: CentOS
Description: CentOS Linux release 7.6.1810 (Core)
Release: 7.6.1810
Codename: Core
Note:
There is no verification in the macOS system and other Linux
distributions.
Justin Mclean <[email protected]> 于2019年11月19日周二 上午5:25写道：
> Hi,
>
> +1 (binding)
>
> This should probably be called RC2 (RC stands for release candidate).
> Putting it in the same spot as the previous one can be confusing.
>
> I checked:
> - incubating in name
> - signatures and hashes fine
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - no unexpected binary files in release
> - all source file have ASF headers
> - can compile but not sure if it's correct (on OSX)
>
> I think the compile instructions can be improved as they are unclear. Some
> of the make commands fail to work e.g. "make check” and running the binary
> gives this error:
> ./apisix:77: module 'tinyyaml' not found: I assume this is just my
> environment.
>
> Thanks,
> Justin
