> I recommend you to submit a pull request about how to release on luarock
at
> the end of this page,
> https://github.com/apache/skywalking-nginx-lua/blob/master/release.md, as
> step 6.
> Then, any SkyWalking committer, including Ming Wen, could do the release
> based on the existing tag.

ok, got it. I will do it later.

On Thu, Apr 9, 2020 at 5:04 PM Sheng Wu <[email protected]> wrote:

> YuanSheng Wang <[email protected]> 于2020年4月9日周四 下午5:00写道:
>
> > Hi:
> >
> > I have removed skywalking-nginx-lua
> > <http://luarocks.org/modules/membphis/skywalking-nginx-lua> in
> > luarocks.org
> > right now. sorry for this.
> >
> > Do we will release `skywalking-nginx-lua` on `luarocks` later?
> >
>
> I think we should.
> I recommend you to submit a pull request about how to release on luarock at
> the end of this page,
> https://github.com/apache/skywalking-nginx-lua/blob/master/release.md, as
> step 6.
> Then, any SkyWalking committer, including Ming Wen, could do the release
> based on the existing tag.
>
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> >
> > Luarocks is the Lua package management tool, which allows users to use it
> > more conveniently.
> >
> >
> > On Thu, Apr 9, 2020 at 4:46 PM Sheng Wu <[email protected]> wrote:
> >
> > > Hi APISIX PPMC and Yuansheng Wang
> > >
> > > First of all, thanks to the APISIX community helps with the SkyWalking
> > > nginx agent.
> > >
> > > Today, when I review the traffic-nginx-lua agent repo traffic[1], this
> > > release page[2] shows up.
> > > If I read this page right, Yuansheng Wang did this release.
> > >
> > > This is not right, because
> > > 1. Yuansheng Wang is not SkyWalking's committer/PMC, he can't do the
> > Apache
> > > release.
> > > 2. The release is 0.1.0[3] according to the community vote and download
> > > page. The 1.0.0 on LuaRocks is quite confusing.
> > >
> > > Look forward to your feedback, we need to work on this ASAP
> > >
> > > [1] https://github.com/apache/skywalking-nginx-lua/graphs/traffic
> > > [2] http://luarocks.org/modules/membphis/skywalking-nginx-lua
> > > [3] http://skywalking.apache.org/downloads/
> > >
> > > Sheng Wu 吴晟
> > > Twitter, wusheng1108
> > >
> >
> >
> > --
> > *MembPhis*
> > My github: https://github.com/membphis
> > Apache APISIX: https://github.com/apache/incubator-apisix
> >
>


-- 
*MembPhis*
My github: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix

Reply via email to