+1 binding

I checked:

   - Download links are valid
   - Checksums are fine
   - No binary file
   - All files have a valid header
   - LICENSE & NOTICE files are good
   - Build successfully on mac os
   - Build Docker image  successfully

Zhiyuan Ju <[email protected]> 于2021年4月10日周六 下午10:34写道:

> Hi,
>
> +1 (binding)
>
> I just checked:
>
> - Downloads links are valid;
> - GPG Signatures are good;
> - files in this package look good to me;
> - NOTICE & License files are ok;
> - Build successfully on Mac (M1).
>
> Just one question: when I running this command:
>
> $ mkdir -p apisix-ingress-controller && tar zxvf
> apache-apisix-ingress-controller-0.5.0-src.tgz-C
> ./apisix-ingress-controller && cd apisix-ingress-controller
>
> I think it should be:
>
> $ mkdir -p apisix-ingress-controller && tar zxvf
> apache-apisix-ingress-controller-0.5.0-src.tgz -C
> ./apisix-ingress-controller && cd apisix-ingress-controller
>
> Best Regards!
> @ Zhiyuan Ju <https://github.com/juzhiyuan>
>
>
> JunXu Chen <[email protected]> 于2021年4月10日周六 下午9:23写道:
>
> > +1
> >
> > I checked:
> > - download link are fine
> > - gpg signature is fine
> > - has ASF header
> > - has LICENSE and NOTICE files
> > - build successfully on Ubuntu 18.04
> >
> >
> > On Sat, 10 Apr 2021 at 15:19, Chao Zhang <[email protected]> wrote:
> >
> > > Hello, Community,
> > >
> > > This is a call for the vote to release Apache apisix-ingress-controller
> > > version 0.5.0 .
> > >
> > > Release notes:
> > >
> > >
> > >
> >
> https://github.com/apache/apisix-ingress-controller/blob/v0.5.0/CHANGELOG.md#050
> > >
> > > The release candidates:
> > >
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.5.0/
> > >
> > > Git tag for the release:
> > >
> > > https://github.com/apache/apisix-ingress-controller/releases/tag/0.5.0
> > >
> > > Release Commit ID:
> > >
> > >
> > >
> >
> https://github.com/apache/apisix-ingress-controller/commit/a492349d1d3f5703acdb784037da47c2082e7512
> > >
> > > Keys to verify the Release Candidate:
> > >
> > > https://dist.apache.org/repos/dist/dev/apisix/KEYS
> > >
> > > Steps to validate the release:
> > >
> > > 1.Download the release file
> > >
> > > $ wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.5.0/apache-apisix-ingress-controller-0.5.0-src.tgz
> > >
> > > 2.Checksums and signatures
> > >
> > > $ wget https://dist.apache.org/repos/dist/dev/apisix/KEYS
> > > $ wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.5.0/apache-apisix-ingress-controller-0.5.0-src.tgz.asc
> > > $ wget
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-0.5.0/apache-apisix-ingress-controller-0.5.0-src.tgz.sha512
> > >
> > > $ shasum -c apache-apisix-ingress-controller-0.5.0-src.tgz.sha512
> > > $ gpg --import KEYS
> > > # Input "trust", then input number 5, then input "save"$ gpg --edit-key
> > > "Chao Zhang"
> > > $ gpg --verify apache-apisix-ingress-controller-0.5.0-src.tgz.asc
> > > apache-apisix-ingress-controller-0.5.0-src.tgz
> > >
> > > 3. Unzip and Check files
> > >
> > > $ mkdir -p apisix-ingress-controller && tar zxvf
> > > apache-apisix-ingress-controller-0.5.0-src.tgz-C
> > > ./apisix-ingress-controller && cd apisix-ingress-controller
> > >
> > > 4. Build
> > >
> > > Please refer to
> > > http://apisix.apache.org/docs/ingress-controller/development
> > > .
> > >
> > > The vote will keep open at least 72 hours or reaches the necessary
> number
> > > of approved votes.
> > >
> > > Please vote accordingly:
> > > [ ] +1 Approve
> > > [ ] +0 No Opinion
> > > [ ] -1 Disapprove with your reason
> > > Thanks!
> > >
> >
>

Reply via email to