Hi Zhiyuan,

Glad to see preview supported by Netlify is re-enabled in apisix-website 
repository!

Regards,
Yilin Zeng
________________________________
发件人: juzhiy...@apache.org <juzhiy...@apache.org>
发送时间: 2021年12月13日 10:22
收件人: dev@apisix.apache.org <dev@apisix.apache.org>
主题: Re: [DISCUSS] Use Netlify to build web projects' preview site

Hi,

Netlify is enabled in apisix-website, and from now on, we could use Preview
URL to review PR changes :)

Also, I just submitted the application to Netlify and waiting for reply.

Best Regards!
@ Zhiyuan Ju <https://github.com/juzhiyuan>


Baoyuan <baoyuan....@gmail.com> 于2021年12月13日周一 09:23写道:

> Agree! This is very convenient and friendly for both contributors and PR
> reviewers.
>
> Shivam Singh <shivam152...@gmail.com> 于2021年12月13日周一 上午3:56写道:
>
> > Oh, I missed the "note" part, just read again and found it. Please ignore
> > the above reply on positioning suggestions.
> > LGTM.
> >
> > Best regards !
> > Shivam Singh
> > <https://github.com/1502shivam-singh>
> >
> > On Mon, Dec 13, 2021 at 1:01 AM Shivam Singh <shivam152...@gmail.com>
> > wrote:
> >
> > > Sounds good !
> > > We can settle this component somewhere around in the footer of the
> > > website, if that's not an issue with the organization standards.
> > >
> > > Best regards !
> > > Shivam Singh
> > > <https://github.com/1502shivam-singh>
> > >
> > > On Sun, Dec 12, 2021 at 8:06 PM Zhiyuan Ju <juzhiy...@apache.org>
> wrote:
> > >
> > >> Hi Community,
> > >>
> > >> We Apache APISIX Community has 2 web projects for now:
> apisix-website[1]
> > >> and apisix-dashboard[2]. When contributors submit PRs, we could use
> the
> > >> 3rd
> > >> platform Netlify[3] to build that PR's Preview site, it's very easy
> for
> > >> reviewers to review that PR's changes, and it also takes a good
> > Developer
> > >> Experience for all of us :)
> > >>
> > >> Today I sent a mail to Netlify's Support Team to apply for the OSS
> > >> plan[4],
> > >> and just received the reply:
> > >>
> > >> ```
> > >> You’ll need to deploy the Preview site on Netlify in order for us to
> > >> approve the Open Source application.
> > >>
> > >> Additionally, we would appreciate a link to our service on your
> projects
> > >> preview site for your website's visitors to see (so, not just in your
> > >> repository documentation or on a sponsors page). You have two options:
> > we
> > >> have pre-made badges (https://www.netlify.com/press/#badges) for your
> > >> convenience, or you may create your own link, which should read “This
> > site
> > >> is powered by Netlify”. Either should link back to our home page,
> > >> https://www.netlify.com.
> > >>
> > >> Please let us know if you have any other questions or once you’ve
> > deployed
> > >> the preview site on Netlify. Thanks!
> > >> ```
> > >>
> > >> I have checked Netlify's requirements, we need to add Netlify's Link
> on
> > >> the
> > >> Preview Site, please note: it's not on the ASF's Official Site, so
> it's
> > >> good to go to integrate Netlify's Service IMO.
> > >>
> > >> - For apisix-website, we could use a Custom Web Component to include
> the
> > >> Netlify Link, and because we don't need to release website source
> code,
> > so
> > >> it works.
> > >> - For apisix-dashboard, we could remove the Netlify Component before
> > >> releasing, so it works as well IMO.
> > >>
> > >> What do you think?
> > >>
> > >> [1] https://github.com/apache/apisix-website
> > >> [2] https://github.com/apache/apisix-dashboard
> > >> [3] http://netlify.com/
> > >> [4] https://www.netlify.com/open-source/
> > >>
> > >> Best Regards!
> > >> @ Zhiyuan Ju <https://github.com/juzhiyuan>
> > >>
> > >
> >
>

Reply via email to