+1 (non-binding)

I checked:
- All links are valid
- Download links are valid
- Checksums and PGP signatures are valid
- LICENSE and NOTICE files are good
- Build successfully on Ubuntu 20.04

JunXu Chen <chenju...@apache.org> 于2021年12月31日周五 20:52写道:

> +1 (binding)
>
> I checked:
> - Download links are valid
> - Checksums and PGP signatures are valid
> - LICENSE and NOTICE files are good
> - Build successfully on Ubuntu 20.04.3
>
> On Fri, 31 Dec 2021 at 18:44, ZhengSong Tu <tzssanggl...@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > I checked:
> > - All links are valid
> > - LICENSE and NOTICE files exist
> > - The Signature is good, the checksum is correct
> >
> > *ZhengSong Tu*
> > My GitHub: https://github.com/tzssangglass
> > Apache APISIX: https://github.com/apache/apisix
> >
> > wei jin <k...@apache.org> 于2021年12月31日周五 18:17写道:
> > >
> > > +1 binding
> > >
> > > I have checked:
> > >
> > > - All links are valid
> > > - LICENSE and NOTICE files exist
> > > - The Signature is good, the checksum is correct
> > > - Build successfully on mac
> > > - Version and commit_id are correct
> > >
> > > Jintao Zhang <zhangjintao9...@gmail.com> 于2021年12月31日周五 14:00写道:
> > >
> > > > Thanks for your suggestion.
> > > >
> > > > Tsangleslie <leslie.ts...@icloud.com.invalid> 于2021年12月31日周五
> 11:59写道:
> > > >
> > > > > BTW, step 3 should add `\` to avoid line breaks
> > > > > Like this:
> > > > >
> > > > > mkdir -p apisix-ingress-controller && tar zxvf \
> > > > > apache-apisix-ingress-controller-1.4.0-src.tgz -C \
> > > > > ./apisix-ingress-controller && cd apisix-ingress-controller
> > > > >
> > > > > Leslie Tsang
> > > > > leslie.ts...@icloud.com
> > > > >
> > > > >
> > > > >
> > > > > > On 30 Dec 2021, at 12:22 AM, Jintao Zhang <
> > zhangjintao9...@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > Hello, Community,
> > > > > > This is a call for the vote to release Apache APISIX Ingress
> > controller
> > > > > > version 1.4.0.
> > > > > >
> > > > > > Release notes:
> > > > > >
> > > > > >
> > > > >
> > > >
> >
> https://github.com/apache/apisix-ingress-controller/blob/v1.4.0/CHANGELOG.md#140
> > > > > >
> > > > > > The release candidates:
> > > > > >
> > > > > >
> > > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.0/
> > > > > >
> > > > > > Git tag for the release:
> > > > > >
> > > > > > https://github.com/apache/apisix-ingress-controller/tree/v1.4.0
> > > > > >
> > > > > > Release Commit ID:
> > > > > >
> > > > > >
> > > > >
> > > >
> >
> https://github.com/apache/apisix-ingress-controller/commit/b7dd90ad9d6a5102fe67c91c29ab76fc4bad4b1a
> > > > > >
> > > > > > Keys to verify the Release Candidate:
> > > > > >
> > > > > > https://dist.apache.org/repos/dist/dev/apisix/KEYS
> > > > > >
> > > > > > Steps to validating the release:
> > > > > >
> > > > > > 1. Download the release
> > > > > >
> > > > > > wget
> > > > > >
> > > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.0/apache-apisix-ingress-controller-1.4.0-src.tgz
> > > > > >
> > > > > >
> > > > > > 2. Checksums and signatures
> > > > > >
> > > > > > wget https://dist.apache.org/repos/dist/dev/apisix/KEYS
> > > > > >
> > > > > > wget
> > > > > >
> > > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.0/apache-apisix-ingress-controller-1.4.0-src.tgz.asc
> > > > > >
> > > > > > wget
> > > > > >
> > > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.0/apache-apisix-ingress-controller-1.4.0-src.tgz.sha512
> > > > > >
> > > > > > gpg --import KEYS
> > > > > >
> > > > > > shasum -c apache-apisix-ingress-controller-1.4.0-src.tgz.sha512
> > > > > >
> > > > > > gpg --verify
> > > > > > apache-apisix-ingress-controller-1.4.0-src.tgz.asc
> > > > > > apache-apisix-ingress-controller-1.4.0-src.tgz
> > > > > >
> > > > > > 3. Unzip and Check files
> > > > > >
> > > > > > mkdir -p apisix-ingress-controller && tar zxvf
> > > > > > apache-apisix-ingress-controller-1.4.0-src.tgz -C
> > > > > > ./apisix-ingress-controller && cd apisix-ingress-controller
> > > > > >
> > > > > > 4. Build
> > > > > >
> > > > > > Please refer to
> > > > > http://apisix.apache.org/docs/ingress-controller/development
> > > > > > .
> > > > > >
> > > > > > The vote will be open for at least 72 hours or until necessary
> > number
> > > > of
> > > > > > votes are reached.
> > > > > >
> > > > > > Please vote accordingly:
> > > > > >
> > > > > > [ ] +1 approve
> > > > > > [ ] +0 no opinion
> > > > > > [ ] -1 disapprove with the reason
> > > > > >
> > > > > > Thanks!
> > > > >
> > > > >
> > > >
> >
>

Reply via email to