Hi, +1 (binding) from me
I just checked: 1. Most links are valid except for the final Development link because it has been removed. Please use https://github.com/apache/apisix-ingress-controller/blob/v1.4.0/docs/en/latest/development.md 2. NOTICE and LICENSE files exist (We could update the NOTICE file's date to 2022?) 3. Build successfully on M1 4. Checksum and Signature are good. Best Regards! @ Zhiyuan Ju <https://github.com/juzhiyuan> Zhihuang Lin <zhihu...@api7.ai> 于2022年5月7日周六 09:51写道： > +1 (no-binding) > > I checked: > 1. http://apisix.apache.org/docs/ingress-controller/development is an > invalid link, no problem with other links. > 2. Checksum and Signature valid > 3. LICENSE and NOTICE exists > > On Wed, May 4, 2022 at 10:40 AM Kwanhur Huang <huang_hua2...@163.com> > wrote: > > > Thanks! > > > > +1 (no-binding) > > > > I checked: > > > > 1. All the links valid > > 2. Checksum and Signature valid > > 3. LICENSE and NOTICE exists > > > > > > Kwanhur Huang > > TL;DR > > > > > 2022年5月4日 上午6:36，Jintao Zhang <zhangjintao9...@gmail.com> 写道： > > > > > > @Kwanhur Huang > > > > > > Thanks for your check and reply. > > > In fact the WARNING you see is just because you didn't trust my key. > > > > > > If you trust my KEY, then you can do: > > > > > > ``` > > > gpg --edit-key "Jintao Zhang <zhangjin...@apache.org>" trust > > > ``` > > > > > > and select `I trust ultimately` , then you won't see WARNING again > after > > > that. > > > > > > > > > ``` > > > # gpg --verify apache-apisix-ingress-controller-1.4.1-src.tgz.asc > > > apache-apisix-ingress-controller-1.4.1-src.tgz > > > gpg: Signature made Fri Apr 29 06:11:53 2022 UTC > > > gpg: using RSA key > > 983B64818EE9E1A22DE5FFB5D23A11ABA758DA2D > > > gpg: checking the trustdb > > > gpg: marginals needed: 3 completes needed: 1 trust model: pgp > > > gpg: depth: 0 valid: 1 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 1u > > > gpg: Good signature from "Jintao Zhang <zhangjin...@apache.org>" > > [ultimate] > > > ``` > > > > > > > > > Chever John <cheverjonat...@gmail.com> 于2022年5月1日周日 00:21写道： > > > > > >> +1 （no-binding） > > >> > > >> I checked: > > >> > > >> 1. All the links are valid; > > >> 2. LICENSE and NOTICE files exists; > > >> 3. Build successfully. > > >> > > >> > > >> On Apr 29, 2022 at 14:32:55, Jintao Zhang <zhangjin...@apache.org> > > wrote: > > >> > > >>> Hello, Community, > > >>> This is a call for the vote to release Apache APISIX Ingress > controller > > >>> version 1.4.1. > > >>> > > >>> Release notes: > > >>> > > >>> > > >>> > > >> > > > https://github.com/apache/apisix-ingress-controller/blob/v1.4.0/CHANGELOG.md#141 > > >>> > > >>> The release candidates: > > >>> > > >>> > > >>> > > >> > > > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.1/ > > >>> > > >>> Git tag for the release: > > >>> > > >>> https://github.com/apache/apisix-ingress-controller/tree/v1.4.1 > > >>> > > >>> Release Commit ID: > > >>> > > >>> > > >>> > > >> > > > https://github.com/apache/apisix-ingress-controller/commit/3b5798dee7a31e7d0c41ff8bca8230d393683cde > > >>> > > >>> Keys to verify the Release Candidate: > > >>> > > >>> https://dist.apache.org/repos/dist/dev/apisix/KEYS > > >>> > > >>> Steps to validating the release: > > >>> > > >>> 1. Download the release > > >>> > > >>> wget > > >>> > > >>> > > >> > > > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.1/apache-apisix-ingress-controller-1.4.1-src.tgz > > >>> > > >>> > > >>> 2. Checksums and signatures > > >>> > > >>> wget https://dist.apache.org/repos/dist/dev/apisix/KEYS > > >>> > > >>> wget > > >>> > > >>> > > >> > > > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.1/apache-apisix-ingress-controller-1.4.1-src.tgz.asc > > >>> > > >>> wget > > >>> > > >>> > > >> > > > https://dist.apache.org/repos/dist/dev/apisix/apisix-ingress-controller-1.4.1/apache-apisix-ingress-controller-1.4.1-src.tgz.sha512 > > >>> > > >>> gpg --import KEYS > > >>> > > >>> shasum -c apache-apisix-ingress-controller-1.4.1-src.tgz.sha512 > > >>> > > >>> gpg --verify apache-apisix-ingress-controller-1.4.1-src.tgz.asc > > >>> apache-apisix-ingress-controller-1.4.1-src.tgz > > >>> > > >>> 3. Unzip and Check files > > >>> > > >>> mkdir -p apisix-ingress-controller && tar zxvf > > >>> apache-apisix-ingress-controller-1.4.1-src.tgz -C > > >>> ./apisix-ingress-controller && cd apisix-ingress-controller > > >>> > > >>> 4. Build > > >>> > > >>> Please refer to > > >>> http://apisix.apache.org/docs/ingress-controller/development > > >>> . > > >>> > > >>> The vote will be open for at least 72 hours or until necessary number > > of > > >>> votes are reached. > > >>> > > >>> Please vote accordingly: > > >>> > > >>> [ ] +1 approve > > >>> [ ] +0 no opinion > > >>> [ ] -1 disapprove with the reason > > >>> > > >>> Thanks! > > >>> > > >> > > > > >
