Hi all.

Attached is a patch that fixes the apr configure script
so that it uses --enable-debug and --enable-maintainer-mode
instead of --with-debug and --with-maintainer-mode.

The AC_ARG_WITH macro should not be used to turn optional
features on. Here is a quick snip from the manual:

"For each external software package that may be used, `configure.in' 
should call AC_ARG_WITH to detect whether the
configure user asked to use it."

Comparing this to the AC_ARG_ENABLE manual entry
shows that the apr usage is not correct:

"For each optional feature, `configure.in' should call
AC_ARG_ENABLE to detect whether the configure user
asked to include it."

Mo DeJong
Red Hat Inc

Index: configure.in
===================================================================
RCS file: /home/cvspublic/apr/configure.in,v
retrieving revision 1.257
diff -u -r1.257 configure.in
--- configure.in        2001/03/06 19:22:26     1.257
+++ configure.in        2001/03/18 01:21:11
@@ -78,10 +78,10 @@
 '
 echo $ac_n "${nl}Check for compiler flags..."
 
-AC_ARG_WITH(debug,[  --with-debug            Turn on debugging and compile 
time warnings],
+AC_ARG_ENABLE(debug,[  --enable-debug            Turn on debugging and compile 
time warnings],
         [if test "$GCC" = "yes"; then CFLAGS="$CFLAGS -g -Wall"; else 
CFLAGS="$CFLAGS -g"; fi])
 
-AC_ARG_WITH(maintainer-mode,[  --with-maintainer-mode  Turn on debugging and 
compile time warnings],
+AC_ARG_ENABLE(maintainer-mode,[  --enable-maintainer-mode  Turn on debugging 
and compile time warnings],
         [if test "$GCC" = "yes"; then CFLAGS="$CFLAGS -g -Wall 
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations"; else 
CFLAGS="$CFLAGS -g"; fi])
 
 dnl # this is the place to put specific options for platform/compiler

Reply via email to