"William A. Rowe, Jr." wrote:
>
> See apr/include/apr_errno.h for the appropriate templates, just follow right
> along :-) EFTYPE would be appropriate all over, say if a loaded module
> doesn't
> have the appropriate entry point or data export to be an apache module, etc.
Ok, I will add APR_EFTYPE to APR. and arrange apr_iconv
The patch for apr/include/apr_errno.h could be the one proposed in attachement.
Please check it.
>
> Bill
>
> ----- Original Message -----
> From: "jean-frederic clere" <[EMAIL PROTECTED]>
> To: "William A. Rowe, Jr." <[EMAIL PROTECTED]>
> Cc: <[email protected]>
> Sent: Tuesday, May 22, 2001 4:18 AM
> Subject: Re: cvs commit: apr-iconv/lib iconv_module.c
>
> > "William A. Rowe, Jr." wrote:
> > >
> > > > jfclere 01/05/22 00:40:31
> > > >
> > > > Modified: lib iconv_module.c
> > > > Log:
> > > > Change EFTYPE into APR_ICONV_EFTYPE (EFTYPE is used by FreeBSD).
> > > >
> > > > - return EFTYPE;
> > > > + return APR_ICONV_EFTYPE;
> > >
> > > Guys, in case we missed the point from the earlier conversion, we have to
> > > quit inventing 'custom specific error codes' when plain old obvious codes
> > > can be assigned!!! If that means APR_EFTYPE, then fine, but please, lets
> > > not get too specific!
> >
> > Apr-iconv logic was using EFTYPE to tell that the converter needs another
> > converter.
> > In FreeBSD I have found:
> > #define EFTYPE 79 /* Inappropriate file type or
> > format */
> >
> > What should I do? Add APR_EFTYPE to APR, but the modules that uses it is an
> > internal module of apr-iconv.
> >
> > >
> > > Bill
> >
Index: apr/include/apr_errno.h
===================================================================
RCS file: /home/cvs/apache/apr/include/apr_errno.h,v
retrieving revision 1.64
diff -u -r1.64 apr_errno.h
--- apr/include/apr_errno.h 2001/05/19 22:47:28 1.64
+++ apr/include/apr_errno.h 2001/05/22 10:54:04
@@ -471,6 +471,12 @@
#define APR_ENETUNREACH (APR_OS_START_CANONERR + 22)
#endif
+#ifdef EFTYPE
+#define APR_EFTYPE
+#else
+#define APR_EFTYPE (APR_OS_START_CANONERR + 23)
+#endif
+
#if defined(OS2)
@@ -582,6 +588,7 @@
|| (s) == APR_OS_START_SYSERR + SOCEHOSTUNREACH)
#define APR_STATUS_IS_ENETUNREACH(s) ((s) == APR_ENETUNREACH \
|| (s) == APR_OS_START_SYSERR + SOCENETUNREACH)
+#define APR_STATUS_IS_EFTYPE(s) (s) == APR_EFTYPE)
/*
Sorry, too tired to wrap this up for OS2... feel free to
@@ -741,6 +748,7 @@
#define APR_STATUS_IS_ETIMEDOUT(s) ((s) == APR_ETIMEDOUT)
#define APR_STATUS_IS_EHOSTUNREACH(s) ((s) == APR_EHOSTUNREACH)
#define APR_STATUS_IS_ENETUNREACH(s) ((s) == APR_ENETUNREACH)
+#define APR_STATUS_IS_EFTYPE(s) ((s) == APR_EFTYPE)
#endif /* !def OS2 || WIN32 */
