You think I would have looked at the reply-to address before sending, but no, that would have been too easy.


This may have been the stack-smashing bug that I've been trying to track down on Mac OS X. (Mark Benedetto King *just* tracked it down on the OS X side toox).

We now return you to your regularly scheduled commit messages.

-Fitz

On Wednesday, February 6, 2002, at 04:09  PM, B. W. Fitzpatrick wrote:


Gaaaaaaaaaaaaaaaaaaaahhhhhhhhhhhhhhhhhhhhhhhhhhh. This may have been the bug


-Fitz

On Wednesday, February 6, 2002, at 03:01  PM, [EMAIL PROTECTED] wrote:

striker     02/02/06 13:01:36

  Modified:    memory/unix apr_pools.c
  Log:
  Fix a bug where we are NULL'ing too many bytes.

  Submitted by: William A. Rowe

  Revision  Changes    Path
  1.150     +2 -2      apr/memory/unix/apr_pools.c

  Index: apr_pools.c
  ===================================================================
  RCS file: /home/cvs/apr/memory/unix/apr_pools.c,v
  retrieving revision 1.149
  retrieving revision 1.150
  diff -u -r1.149 -r1.150
  --- apr_pools.c       5 Feb 2002 12:09:43 -0000       1.149
  +++ apr_pools.c       6 Feb 2002 21:01:36 -0000       1.150
  @@ -240,7 +240,7 @@
       if (apr_pools_initialized++)
           return APR_SUCCESS;

  -    memset(&global_allocator, 0, SIZEOF_ALLOCATOR_T);
  +    memset(&global_allocator, 0, sizeof(global_allocator));

if ((rv = apr_pool_create_ex(&global_pool, NULL, NULL, APR_POOL_FDEFAULT)) != APR_SUCCESS) {
return rv;
@@ -269,7 +269,7 @@
apr_pool_destroy(global_pool); /* This will also destroy the mutex */
global_pool = NULL;


  -    memset(&global_allocator, 0, SIZEOF_ALLOCATOR_T);
  +    memset(&global_allocator, 0, sizeof(global_allocator));
   }

   #ifdef NETWARE




-Fitz

--
Brian Fitzpatrick
Senior Consulting Engineer
Apple Professional Services
312-902-7384 (Office)




Reply via email to