> size_t len = strlen(str) + 1; > > if (!(sdup = (char *) malloc(len))) { > - /* ### whoops! we can't call Apache logging routines here... */ > -#if 0 > - apr_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0, NULL, > - "Ouch! Out of memory in our strdup()!"); > -#endif > return NULL; > } > memcpy(sdup, str, len);
Do we really need to check for out-of-memory here? Let's save the if(). -aaron