Looking at the problem behind PR 12616 exposes some brokenness with error handling in apr_rmm_*().
Example 1: apr_rmm_malloc() can return apr_status_t if a lock operation fails or an apr_rmm_off_t otherwise. How can the caller know which it is? Example 2: apr_rmm_realloc() checks for a negative return code from apr_rmm_malloc(). The return code can't be negative because of the data type (not to mention the logic of apr_rmm_malloc()). -- Jeff Trawick | [EMAIL PROTECTED] Born in Roswell... married an alien...
