It looks ok, but I think my objection was that everything else in finfo is authoritative. This field might be mis-capitalized (on case-insensitive platforms), unrooted, or whatever.
Patch committed, but I think we need to call this out in documentation. Bill At 12:44 PM 11/18/2003, Geoffrey Young wrote: >hi all > >it looks like finfo->fname is missing from filestat.c on win32 - on unix, the >call is made right after assigning the pool in apr_file_info_get. > >anyway, here is a quick patch against 0.9 branch. I have no way to test it, >or know what the issues are (whether it is just missing or there is a reason >for it), but just in case... > >--Geoff > > >Index: srclib/apr/file_io/win32/filestat.c >=================================================================== >RCS file: /home/cvspublic/apr/file_io/win32/filestat.c,v >retrieving revision 1.81 >diff -u -r1.81 filestat.c >--- srclib/apr/file_io/win32/filestat.c 7 Jul 2003 22:44:10 -0000 1.81 >+++ srclib/apr/file_io/win32/filestat.c 18 Nov 2003 18:42:27 -0000 >@@ -445,6 +445,7 @@ > } > > finfo->pool = thefile->pool; >+ finfo->fname = thefile->fname; > > /* Extra goodies known only by GetFileInformationByHandle() */ > finfo->inode = (apr_ino_t)FileInfo.nFileIndexLow
