Julian Foad <[EMAIL PROTECTED]> writes: > This patch contains all of the changes I have posted so far in this > thread, and more, now as a Subversion diff, with log messages. > > The one bug fixed here is that the functions apr_signal_block and > apr_signal_unblock were not being implemented because they were > testing for APR_HAS_SIGACTION instead of APR_HAVE_SIGACTION. > > All of the other changes are to resolve inconsistencies that I found > from compiler warnings. (SuSE 9.1 GNU/Linux, GCC 3.3.3 with extra > warnings enabled). > > - Julian > > Fix some inconsistencies and a bug that compiler warnings alerted me to. > > * apr/acconfig.h > Test whether "BEOS" is defined, not whether it is non-zero. > > * apr/file_io/unix/tempdir.c > (test_tempdir): Remove "const" to avoid casting it away. > > * apr/network_io/unix/sendrecv.c > (apr_socket_sendfile): Remove a spurious carriage return from the source. > > * apr/threadproc/unix/signals.c > (apr_signal_block, apr_signal_unblock): Test the correct symbol, so that > these functions will actually be implemented on appropriate platforms.
Even though these are all "cleanups", that's basically the only thing they have in common. (Well, possibly 1 and 4 could be combined, but even that's questionable). I think it would be mildly better for them to be four separate commits. > [diffs for above omitted] > Fix some inconsistencies that compiler warnings alerted me to. > No functional change. > > * apr-util/crypto/apr_md5.c > (apr_md5_encode): Remove unnecessary type casts that were casting away > "const". > > * apr-util/misc/apr_queue.c > Include the header that defines the symbols we are testing. Similar sentiment applies to these. Wow, you are Mr. Cleanup this month! (Not complaining, mind you.) -K
