When invoking apr-iconv's buildconf, a warning is printed because
the APR_FIND_APR macro is invoked without parameters.
As a result, a warning is printed.

The attached patch invokes APR_FIND_APR with the 4th arg set to "0 1",
suppressing the warning, but my question is whether support for apr-0.x
should really be maintained (and if so, is is valid to use a parameter
in APR_FIND_APR's invocation at all?)

Probably the 4th arg should be set to [1] (or not at all).
I am unsure about the philosophy behind the APR_FIND_APR's API change,
and apr-iconv's usage scenario, that's why I wanted to ask here first.

  Martin
-- 
<[EMAIL PROTECTED]>         |     Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730  Munich,  Germany
Index: build/apr-iconv.m4
===================================================================
--- build/apr-iconv.m4  (Revision 126171)
+++ build/apr-iconv.m4  (Arbeitskopie)
@@ -8,7 +8,7 @@
 AC_DEFUN(API_FIND_APR,[
 
   dnl use the find_apr.m4 script to locate APR. sets apr_found and apr_config
-  APR_FIND_APR
+  APR_FIND_APR(,,,[0 1])
   if test "$apr_found" = "no"; then
     AC_MSG_ERROR(APR could not be located. Please use the --with-apr option.)
   fi

Reply via email to