On 12/27/05, Curt Arnold <[EMAIL PROTECTED]> wrote: > > On Dec 22, 2005, at 5:03 PM, Garrett Rooney wrote: > > > On 12/22/05, Curt Arnold <[EMAIL PROTECTED]> wrote: > > > >> I concur with the suggested change in http://issues.apache.org/ > >> bugzilla/show_bug.cgi?id=37650. My message on it was http:// > >> marc.theaimsgroup.com/?l=apr-dev&m=113511544618645&w=2. > > > > Committed in r358652. For some reason I had assumed that the problem > > would show up in more places than just that one. > > Good assumption. Neither the original reporter or I appeared to > attempt to successfully build apr-iconv under gcc 4, but just > analyzed the first encountered error. There appear to be three other > files that have a similar problem and they aren't as trivial. I've > take a stab at them in an attachment to bug 37650 and reopened the bug.
I took a look at this, but the new patch appears to cause some compile warnings (not that this code is totally warning free in the first place, but I'd rather not make the problem worse). $ make 1>/dev/null iconv_ces_iso2022.c: In function 'apr_iconv_iso2022_convert_to_ucs': iconv_ces_iso2022.c:298: warning: pointer targets in assignment differ in signedness iconv_ccs.c: In function 'apr_iconv_ccs_event': iconv_ccs.c:47: warning: assignment discards qualifiers from pointer target typeucs2-internal.c: In function 'convert_from_ucs': ucs2-internal.c:63: warning: assignment makes pointer from integer without a cast ucs2-internal.c: In function 'convert_to_ucs': ucs2-internal.c:75: warning: initialization from incompatible pointer type ucs2-internal.c:76: warning: return makes integer from pointer without a cast ucs4-internal.c: In function 'convert_from_ucs': ucs4-internal.c:61: warning: assignment makes pointer from integer without a cast ucs4-internal.c: In function 'convert_to_ucs': ucs4-internal.c:74: warning: return makes integer from pointer without a cast $ The warnings in ucs2-internal.c and ucs4-internal.c are new, added by this patch. -garrett
