Lucian Adrian Grijincu wrote:
On 10/14/07, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote:
Lucian Adrian Grijincu wrote:
isn't this why they invented comments?

why [...] when you can do:
   return x; //and place a witty comment here?

saves a cmp and a jump.
Just forewarn - // isn't portable, please don't litter :)  More than happy to 
see
/* */ style comments.

Sorry for being ignorant :). I'll try to remember that.

I wouldn't have said anything if it wasn't the #2 most common mistake, right 
after
using tabs instead of spaces :)  I know - MS spoils us by calling their C++ 
compiler
a C compiler ;-)

I think someone with Netware experience should review this code.

Yes, if you weren't aware, patch is very tolerant of # comments, so you can 
attach
your patch with something like...

# Patch to clean up the code flow, but this needs review by a netware guru
# because...
#
Index: threadproc/netware/thread.c
===================================================================
--- threadproc/netware/thread.c (revision 584412)
+++ threadproc/netware/thread.c (working copy)
@@ -125,19 +125,14 @@
        /* int *error */        
...

which is not only clear to the reader, but applies without changes via patch.

Bill

Reply via email to