On 06/30/2008 08:28 PM, Tom Donovan wrote:
William A. Rowe, Jr. wrote:
Guys, please take a look, looks like one of the 1.3.x generation patches
has broken our API compatibility rules.
It looks like this has always been wrong in mod_python.
APR_BRIGADE_SENTINEL takes a brigade argument, not a bucket.
I agree. This has been the case for as long as I can remember and svn blame
proves that this has been this way for ages:
http://svn.apache.org/viewvc?view=rev&revision=58049
refs:
http://apr.apache.org/docs/apr-util/1.3/group___a_p_r___util___bucket___brigades.html#g858da66dccab1e063415678bb115788a
http://apr.apache.org/docs/apr-util/0.9/group__APR__Util__Bucket__Brigades.html#g858da66dccab1e063415678bb115788a
I think no error displayed pre-1.3.2 because, unfortunately, both
buckets and brigades have a member named 'list':
For buckets - 'list' is a pointer to the allocator function.
For brigades, 'list' is the ring of buckets.
The condition was probably never true when he was checking the wrong
kind of 'list' for a brigade sentinel. Well, hopefully it was never true!
Good points.
Regards
Rüdiger
